chore: use the stock js_of_ocaml
#4965
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is some fallout, though, as the `limit.mo` test won't let us to
iterate up to 10000. I had to reduce it to the 7600 mark due to
a stack overflow:
``` diff
> {
result: {
+ error: {}
- error: null
},
+ stderr: 'limit.mo:1.23-1.27: internal error, Stack overflow\n' +
+ '\n' +
+ 'Last environment:\n' +
+ '@ManagementCanister = {}\n' +
+ '@add_cycles = <func>\n' +
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to build v5.0.1 ourselves, as there were correctness problems with v4.1.x. This reverts back to the supplied one that is bundled with OCaml 4.13.
there is some fallout, though, as the
limit.motest won't let us to iterate up to 10000. I had to reduce it to the 7600 mark due to a stack overflow: