Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Operators] Fix #43 - Improved exploit max length for dangling operator #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falcaopetri
Copy link
Contributor

This PR implements the modification proposed in #43. I've updated all mining assistants that I could find in master.

This PR would also benefit assistants on other branches (such as the Injective assistant).

I've run some basic tests with -maxad 3 and -maxad 4, comparing mined rules before and after this patch. TSVRuleDiff reports no difference between mined rules.

This PR is slightly faster than master, and there is a huge performance improvement when mining constants. Also, AMIE queue calls to the last generation drops by about half.

Basic benchmark:

Mean of 5 runs in a 500k triples KB.

Without constants:

Summary
  'java -jar dangling_amie3.jar -bias lazy -oute -full -minhc .1 -maxad 3 kb.nt' ran
    1.02 ± 0.05 times faster than 'java -jar amie3.jar -bias lazy -oute -full -minhc .1 -maxad 3 kb.nt'

With constants:

Summary
  'java -jar dangling_amie3.jar -bias lazy -const -oute -full -minhc .1 -maxad 3 kb.nt' ran
    6.08 ± 0.21 times faster than 'java -jar amie3.jar -bias lazy -const -oute -full -minhc .1 -maxad 3 kb.nt'

Copy link
Collaborator

@lgalarra lgalarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes. They make the logic neater. @lajus since it is a critical piece of code, I will feel more relieved if you also approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants