Skip to content

Abi fetching through StarknetNode datasource #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

baitcode
Copy link
Contributor

@baitcode baitcode commented Jan 29, 2025

Closes #1108

Added abi fetching functionality to StarknetNode datasource.
Updated codegen.
Added abi_lookup method in AbiDatasource. Refactored env and starknet codegen using it.

@baitcode baitcode marked this pull request as draft January 29, 2025 19:44
@baitcode baitcode marked this pull request as ready for review January 30, 2025 00:25
@baitcode baitcode changed the title starknet node abi fetch request Abi fetching through StarknetNode datasource Jan 30, 2025
@droserasprout droserasprout added feature New feature or request community Reported or suggested by our awesome users labels Jan 30, 2025
@baitcode baitcode marked this pull request as draft January 30, 2025 13:08
@baitcode baitcode marked this pull request as ready for review January 30, 2025 13:15
@baitcode
Copy link
Contributor Author

@droserasprout now tested!

@droserasprout
Copy link
Member

@baitcode Please update the demo project as described in my last comment in the linked issue.

@baitcode
Copy link
Contributor Author

baitcode commented Feb 1, 2025

@droserasprout All done!

@droserasprout droserasprout added this to the 8.2.0rc2 milestone Feb 5, 2025
@droserasprout droserasprout merged commit 15e5a9e into dipdup-io:next Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Reported or suggested by our awesome users feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Cairo ABIs from node
2 participants