Only run Bugzilla actions for projects using Bugzilla #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same list of Bugzilla-using projects as when posting the comment to decide whether to interact with Bugzilla.
|
Thanks for your pull request, @CyberShadow! |
Geod24
approved these changes
May 27, 2021
CyberShadow
added a commit
to CyberShadow/dlang-bot
that referenced
this pull request
May 27, 2021
Follow-up to dlang#272. Apply the is-a-Bugzilla-using-project check to the code which parses Bugzilla references and queries details for each from Bugzilla, too. The test suite fallout is larger this time because we need to patch the repo slug in the other-org tests, which means we can't reuse the existing payloads (at least not without introducing a "read this other payload, do a search&replace, and serve it instead" mechanism).
Geod24
pushed a commit
that referenced
this pull request
May 28, 2021
Follow-up to #272. Apply the is-a-Bugzilla-using-project check to the code which parses Bugzilla references and queries details for each from Bugzilla, too. The test suite fallout is larger this time because we need to patch the repo slug in the other-org tests, which means we can't reuse the existing payloads (at least not without introducing a "read this other payload, do a search&replace, and serve it instead" mechanism).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259.
We were already avoiding putting issue numbers in the welcome message for non-Bugzilla projects, but the same logic wasn't being used for deciding whether to run the Bugzilla integrations.