Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20982 - wrong line number in iasmgcc #20993

Merged
merged 1 commit into from
Mar 15, 2025
Merged

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Mar 14, 2025

Still need to test this, the unittest in this module calls parseGccAsm but not gccAsmSemantic.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#20993"

@ibuclaw
Copy link
Member

ibuclaw commented Mar 15, 2025

All gdc tests pass with this now.

PASS: gdc.dg/asm1.d    (test for errors, line 37)
PASS: gdc.dg/asm1.d    (test for errors, line 61)
PASS: gdc.dg/asm1.d    (test for errors, line 66)
PASS: gdc.dg/asm1.d    (test for errors, line 73)
PASS: gdc.dg/asm1.d    (test for errors, line 8)
PASS: gdc.dg/asm1.d    (test for errors, line 89)
PASS: gdc.dg/asm1.d    at line 18 (test for errors, line 17)
PASS: gdc.dg/asm1.d    at line 19 (test for errors, line 17)
PASS: gdc.dg/asm1.d    at line 26 (test for errors, line 25)
PASS: gdc.dg/asm1.d    at line 27 (test for errors, line 25)
PASS: gdc.dg/asm1.d    at line 28 (test for errors, line 25)
PASS: gdc.dg/asm1.d    at line 29 (test for errors, line 25)
PASS: gdc.dg/asm1.d    at line 49 (test for errors, line 48)
PASS: gdc.dg/asm1.d    at line 50 (test for errors, line 48)
PASS: gdc.dg/asm1.d   (test for excess errors)

@dkorpel dkorpel marked this pull request as ready for review March 15, 2025 19:16
@dkorpel
Copy link
Contributor Author

dkorpel commented Mar 15, 2025

Good, since there's no easy way to test this in dmd, let's just merge this.

@dkorpel dkorpel merged commit d5e6f49 into dlang:stable Mar 15, 2025
73 of 74 checks passed
@dkorpel dkorpel deleted the iasmgcc-loc branch March 15, 2025 19:16
dkorpel added a commit that referenced this pull request Mar 21, 2025
* bump VERSION to v2.110.0

* purge changelog

* bump VERSION to v2.111.0-beta.1

* Accept __rvalue attribute on ref functions; which will force the result to be treated as __rvalue. (#20946)

This is essential to implement `move`, `forward`, etc.

* memoryerror.d: Fix AnySupported version condition (#20983)

* Fix #20982 - wrong line number in iasmgcc (#20993)

* Move genCfunc to cxxfrontend (#20992)

* druntime: Fix compilation of rt.cover on Android (#21015)

* Expose SourceLoc to C++ interface (#20980)

* [stable] C++ header fixes for declaration, expression, and typinf (#21016)

Seen either from compilation errors or missing symbols at link time.

* C++ headers: Add 3 Declaration bitfield setters/getters required by LDC

* druntime: Add module declaration to rt.invariant, to prevent conflicts with user-provided invariant.d (#21017)

* Fix #21020 - Indexing a *cast* AA yields no lvalue anymore (#21029)

* Add C++23 to CppStdRevision enum (#21043)

* Improve UFCS/property error message (#21046)

---------

Co-authored-by: Manu Evans <turkeyman@gmail.com>
Co-authored-by: Martin Kinkelin <kinke@users.noreply.github.com>
Co-authored-by: Iain Buclaw <ibuclaw@gdcproject.org>
Co-authored-by: Martin Kinkelin <noone@nowhere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants