-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sparse] A hetero-relational GCN example #6157
Conversation
To trigger regression tests:
|
1 similar comment
Overall LGTM, please copy paste the model result to the PR description. |
@frozenbugs I'm not sure what the results include. Is it the performance or the size of the model parameters? |
Just the output of the model, e.g. acc loss e.t.c. for example: #6163 |
@czkkkkkk @jermainewang do know whether Test Acc: 0.4091 is reasonable? |
The train loss looks abnormal. What is the loss of the message passing example? https://github.com/dmlc/dgl/blob/master/examples/core/rgcn/hetero_rgcn.py#L285 |
I find the problem is the missing of matrix normalization, so I add it and new result is updated. The loss now is the same as previous exmaples. However, the accuracy is still a bit lower, we think this is because the Graphconv operator in dgl use more fine-grained optimization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix some minor issues.
It's strange that validation accuracy is much lower than test accuracy. |
I think it is overfit, can you double check? |
It seems not overfit. I test different numbers of epoch, follows are the results of epoch = 5 and 10:
However, I observe an intersting phenomenon that the results of other three datasets seem to be normal.
And follow is the result of 'mutag' dataset:
The result of 'bgs' dataset.
|
I guess there is something wrong with the last dataset, since we find the similar result from current hetero-rgcn implementation: https://github.com/dmlc/dgl/blob/master/examples/pytorch/rgcn-hetero/entity_classify.py |
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Description
Add an example of Relational Graph Convolutional Network (R-GCN) model for node classification on the heterograph.
The training log is as follows:
Checklist
Please feel free to remove inapplicable items for your PR.
Changes