-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix the lazy device copy issue of DGL node/edge features. #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
frozenbugs
approved these changes
Nov 14, 2023
frozenbugs
reviewed
Nov 14, 2023
Failed on some test cases. The lazy copy mechanism appears to be a feature. |
frozenbugs
approved these changes
Nov 21, 2023
peizhou001
pushed a commit
to peizhou001/dgl
that referenced
this pull request
Nov 27, 2023
DominikaJedynak
pushed a commit
to DominikaJedynak/dgl
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #6542.
In the following code snippet
The GPU memory of node and edge features of
split_graphs
is not released properly. This is because when copying the split graphs to CPU, theColumn
, which is the DGL internal feature storage, does not copy data to CPU when Column.to() is called. The copy only happen when Column.data is called. In my fix, I simply copy the data to the device inColumn.to
. I am not sure whether there is any risk to do in this way. @BarclayII, do you have concerns?Checklist
Please feel free to remove inapplicable items for your PR.
Changes