-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt][CUDA] Add gb.index_select
and fix example inferencing.
#7051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
gb.index_select
for example inferencing.gb.index_select
and fix example inferencing.
frozenbugs
reviewed
Feb 1, 2024
frozenbugs
reviewed
Feb 1, 2024
frozenbugs
reviewed
Feb 1, 2024
frozenbugs
approved these changes
Feb 4, 2024
Let's wait for #7083 to be merged first so that I can test the link prediction example in this PR properly. |
gb.index_select
and fix example inferencing.gb.index_select
and fix example inferencing.
Just tested all 4 different modes for the node_prediction example, all work as expected. |
Just tested the link_prediction example with the fix in #7083, all the 4 different modes work as expected. |
gb.index_select
and fix example inferencing.gb.index_select
and fix example inferencing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing example was moving the feature memory to the device memory. We change it to the storage_device instead.
When I started this PR, I thought I would use
gb.index_select
to load features for inferencing. Then I realized that I can just update the features and rely on the dataloader to fetch the features for inferencing. Otherwise, the copies for all the different modes become too complicated and ugly, which the dataloader automatically handles for us. However, I am sure thatgb.index_select
will be useful to us down the road, it is a very simple wrapper overtorch.ops.graphbolt.index_select
.Checklist
Please feel free to remove inapplicable items for your PR.
Changes