Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Make _convert_to_sampled_subgraph lighter. #7312

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Apr 17, 2024

Incorporate rest of the _convert_to_sampled_subgraph into SampleNeighbors.

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested review from frozenbugs and RamonZhou April 17, 2024 21:14
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 17, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin changed the title [GraphBolt][CUDA] Incorporate rest of the `_convert_to_sampled_subgra… [GraphBolt][CUDA] Make _convert_to_sampled_subgraph lighter. Apr 17, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 17, 2024

Commit ID: d99e8ff

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 17, 2024

Commit ID: 543e4a436c6b6219ce64b414e22d93f30ac654d5

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 17, 2024

Commit ID: d99e8ff

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 18, 2024

Commit ID: 4e9fb6ad0610c9cea01a852beed2a42b5e02fb02

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Apr 18, 2024

@frozenbugs looks like lintrunner is broken now.

@mfbalin mfbalin force-pushed the gb_cuda_optimize_hetero_2 branch from e7016df to 9536e9b Compare April 18, 2024 15:51
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 18, 2024

Commit ID: e7016df

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 18, 2024

Commit ID: 3e9e31ebf1c2ba9713f715dcc2d89a99ad7aafeb

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit a3d20dc into dmlc:master Apr 18, 2024
3 checks passed
@mfbalin mfbalin deleted the gb_cuda_optimize_hetero_2 branch April 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants