-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add check for NNZ
in COOToCSR
#7459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
Rhett-Ying
reviewed
Jun 13, 2024
Rhett-Ying
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add dedicated testcase
I'm afraid it's a little bit difficult because we need to construct a COO with more than 2B NNZ for a testcase. |
mfbalin
reviewed
Jun 13, 2024
Rhett-Ying
reviewed
Jun 14, 2024
The CI failed due to glitch in distributed testcases. It's ok to ignore such failures. |
Rhett-Ying
approved these changes
Jun 17, 2024
lijialin03
pushed a commit
to lijialin03/dgl
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add check for the number of non-zero elements (NNZ) during the conversion from COOMatrix to CSRMatrix within the
spmat_op_impl_coo.cc
file.Checklist
Please feel free to remove inapplicable items for your PR.
Changes