Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Add FeatureCache::IndexSelect. #7526

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 15, 2024

Description

This op is needed for zero copy access from the GPU. GPU reading tests will be included in a follow-up PR when I make use of this added functionality.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested review from frozenbugs and Rhett-Ying July 15, 2024 21:38
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 15, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 15, 2024

Commit ID: 3c0ed42

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 15, 2024

Commit ID: b46561d

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 15, 2024

Commit ID: e5553f8

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 16, 2024

Commit ID: ec688f794dd763eae7052e7a02d7c17d393e9c7c

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 16, 2024

Commit ID: dca0aca8eaabacb9d565c3dec5f7d02176172462

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 16, 2024

Commit ID: 08216c1f55b0f3764623636bfb268be6fddd2d1d

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 16, 2024

Commit ID: f612ac612e41e4cf9994bd4bb123aeee88791886

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

Index select and pin memory are not related, could be 2 small prs.

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 16, 2024

Index select and pin memory are not related, could be 2 small prs.

Indeed.

@mfbalin mfbalin merged commit 0984ad9 into dmlc:master Jul 16, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_feature_cache_query_direct branch July 16, 2024 07:30
lijialin03 pushed a commit to lijialin03/dgl that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants