-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] Refactor and extend FeatureStore
.
#7558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
8 tasks
Feature
s from FeatureStore
.FeatureStore
.
lijialin03
pushed a commit
to lijialin03/dgl
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
expedited
if it doesn't affect the main path approve first to unblock related projects, and review later
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't need to expose
Feature.read_async
and related functions inFeatureStore
. This functionality will let us access the stored Features in FeatureFetcher and we will be able to call the hidden read_async functions as the user will mostly keepFeatureStore objects around, not Features. Moreover, it is possible to provide the implementations of read, update and other functions if we expose a
__getitem__
method, increasing code reuse.It will also make the examples look better and our components easier to use.
dgl/examples/multigpu/graphbolt/node_classification.py
Lines 299 to 303 in 69fd95e
Checklist
Please feel free to remove inapplicable items for your PR.
Changes