Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][io_uring] Make OnDiskNpyArray threadsafe. #7562

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 22, 2024

Description

During our pipelined read_async feature fetch pipeline, it is possible that multiple async workers try to fetch at the same time. It is crucial to make it threadsafe to avoid catastrophic crashes and data races. Needed by #7559.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Jul 22, 2024
@mfbalin mfbalin requested a review from frozenbugs July 22, 2024 07:20
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin changed the title [GraphBolt][io_uring] Make OnDiskNpyArray threadsafe. [GraphBolt][io_uring] Make OnDiskNpyArray threadsafe. Jul 22, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 9de663a

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 8ef4a44 into dmlc:master Jul 22, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_liburing_thread_safe branch July 22, 2024 08:01
lijialin03 pushed a commit to lijialin03/dgl that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants