[GraphBolt] Change hash table for performance. #7631
Merged
+19
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.5x faster compared to phmap. This hash table is used across the industry for its excellent performance. See the benchmark results in https://martin.ankerl.com/2022/08/27/hashmap-bench-01/#benchmark-results-table for reference. We chose to use
tsl::robin_map
for our use case after trying out a few alternatives.@frozenbugs 50% performance improvement is not small so I am hoping it is fine for me to add this hash table dependency.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes