build: Locate SDL by its case-sensitive name #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkg-config file describing SDL's API is `sdl2.pc` or `sdl3.pc`, so the name to look for is `sdl2` or `sdl3`. Looking for it with a different case combination will not necessarily work. With the versions of `pkg-config` and `meson` in Steam Runtime 3 'sniper', it seems that SDL 2 can be found via either case combination, but SDL 3 requires the canonical case combination, `sdl3`. Signed-off-by: Simon McVittie <smcv@collabora.com>
|
I believe SDL2 already worked because Meson has a special case for it (to be able to fall back to |
|
Falling back from pkg-config to CMake might also have been case-insensitive, because CMake is generally case-insensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkg-config file describing SDL's API is
sdl2.pcorsdl3.pc, so the name to look for issdl2orsdl3. Looking for it with a different case combination will not necessarily work.With the versions of
pkg-configandmesonin Steam Runtime 3 'sniper', it seems that SDL 2 can be found via either case combination, but SDL 3 requires the canonical case combination,sdl3.