Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOME doesn't handle absolute paths correctly for an entry point #224

Closed
avivbeeri opened this issue Dec 20, 2021 · 0 comments · Fixed by #227
Closed

DOME doesn't handle absolute paths correctly for an entry point #224

avivbeeri opened this issue Dec 20, 2021 · 0 comments · Fixed by #227
Labels
bug Something isn't working

Comments

@avivbeeri
Copy link
Collaborator

Trying to call > dome /path/from/root/to/application results it in it concatenating the absolute path to the current directory, which is a behavioural regression introduced in the refactoring for 1.7.0
@avivbeeri avivbeeri added the bug Something isn't working label Dec 20, 2021
avivbeeri added a commit that referenced this issue Dec 20, 2021
@avivbeeri
Fixing the absolute path loader [fix #224]
1c37846
@avivbeeri avivbeeri linked a pull request Dec 20, 2021 that will close this issue
Fixing the absolute path loader [fix #224] #227
Merged
avivbeeri added a commit that referenced this issue Dec 21, 2021
@avivbeeri
Merge pull request #227 from domeengine/absolutePathFix
7ed0e04 
Fixing the absolute path loader [fix #224]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing the absolute path loader [fix #224] domeengine/dome
1 participant
@avivbeeri