Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev0.2 to master #8

Merged
merged 6 commits into from
Nov 6, 2022
Merged

Dev0.2 to master #8

merged 6 commits into from
Nov 6, 2022

Conversation

dotX12
Copy link
Owner

@dotX12 dotX12 commented Nov 6, 2022

Big update

  • Rename Message -> Event
  • Added Router
  • Added magic filter from aiogram (F)
  • Added notify_success_handler and EventSubscribe.
  • Multiple handlers no longer respond to the same event.
from waio import Router
from waio.types import Event


router2 = Router(name='Router2')


@router2.message_handler(commands=['start'])
async def text_start(event: Event):
    await event.answer("started...")
from waio import F
@dp.message_handler(
    (F.message.payload.content_type == "image/gif")
    & (F.message.payload.sender.name == "Alex")
    & ((F.message.payload.sender.phone.cast(str)[:4]) == "7928")
)
async def test_magic_filter(event: Event):
    await event.answer(f"Test Filter")

* Rename Message -> Event
* Added Router
* Added magic filter from aiogram (F)
* Added notify_success_handler and EventSubscribe.
* Multiple handlers no longer respond to the same event.
@gitguardian
Copy link

gitguardian bot commented Nov 6, 2022

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4929115 Generic High Entropy Secret ba7f8bd docs/assets/code/first_bot/002.py View secret
4929115 Generic High Entropy Secret ba7f8bd docs/assets/code/first_bot/002.py View secret
4929115 Generic High Entropy Secret 10cfa38 docs/assets/code/first_bot/002.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@dotX12 dotX12 merged commit d73fb11 into master Nov 6, 2022
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2022

This pull request introduces 3 alerts and fixes 8 when merging 924284e into fac5797 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for NotImplemented is not an Exception

fixed alerts:

  • 7 for Unused import
  • 1 for Signature mismatch in overriding method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant