Propose to replace AsyncLock with SemaphoreSlim #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chkr1011, sorry for my ignorance, but during debugging under high load I ended up sometimes with exceptions in AsyncLock. They may have been uncritical, but I realized the way AsyncLock is used can also be covered by SemaphoreSlim.
So I would propose to replace AsyncLock with SemaphoreSlim in the codebase and reduce the maintenace surface.
Unless there are specific perf or functional reasons to keep AsyncLock, please provide the rational.
Thanks,
Martin