Add SBE dependencies to Version.Details & Versions.prop #14698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Apr 8, 2024
mthalman
approved these changes
Apr 8, 2024
MichaelSimons
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/source-build#4286
This PR adds a verison property for Newtonsoft.Json and adds entries for Newtonsoft.Json and Microsoft.ApplicationInsights to the Version.Details file. This is done so that if the dependencies were to be updated in SBE, the n-1 versions of these dependencies would be used instead of the current version. This mitigates having to deal with prebuilts possibly being introduced.
Build with changes (internal Microsoft link)