Skip to content

In Blazor authorization, ensure scheme not specified #10570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SteveSandersonMS opened this issue May 28, 2019 · 0 comments
Closed

In Blazor authorization, ensure scheme not specified #10570

SteveSandersonMS opened this issue May 28, 2019 · 0 comments
Assignees
@SteveSandersonMS
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview8

Comments

@SteveSandersonMS
Copy link
Member

Currently we ignore the “scheme” on any IAuthorizeData because it’s not applicable (we already have the ClaimsPrincipal).

To ensure developers are not confused or misled about what rules apply, we should throw if any nonempty scheme value is set.

I’m not suggesting this is urgent, but I do think we should do it before 3.0 ships.
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label May 28, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview8 milestone May 28, 2019
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. PRI: 1 - Required labels May 28, 2019
SteveSandersonMS added a commit that referenced this issue Jul 16, 2019
@SteveSandersonMS
Ensure schemes aren't used on components authorization. Fixes #10570
a0a5a86
SteveSandersonMS added a commit that referenced this issue Jul 16, 2019
@SteveSandersonMS
Ensure schemes aren't used on components authorization. Fixes #10570
f693617
@mkArtakMSFT mkArtakMSFT added the Done This issue has been fixed label Jul 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview8
Development

No branches or pull requests
2 participants
@SteveSandersonMS @mkArtakMSFT