-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add support for Partitioned Cookies #53224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for contacting us. We're moving this issue to the |
If |
@Ajay100000 Those cookies are not set by ASP.NET they are set by Azure Websites. We cannot change those. You should open a ticket for your Azure subscription asking for that feature. |
AFAICT, |
...to support CHIPS (Cookies Having Independent Partitioned State). Fixes dotnet#53224 Fixes dotnet#55370
@blowdart Has Firefox announced that it's going to support this? Given the simplicity of the options.Cookie.Partitioned = true; vs. options.Cookie.Extensions.Add("partitioned"); What are we rushing here for? If nothing changes like we hope, |
On MDN they seem to contrast it with their own related experiment and indicated that it's not (yet?) supported. |
It seems like all you're losing with the Extensions approach is a warning log if you use it incorrectly? |
In the event that we add support to aspnetcore before it's standardized, it feels like we'd still rather hold off on updating Katana until things are set in stone? |
...to support CHIPS (Cookies Having Independent Partitioned State). Fixes dotnet#53224 Fixes dotnet#55370
#55371 is a viable fix with an approved API, but we're reluctant to lock in the name before the feature is standardized. |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe the problem.
CookieBuilder should support the new Partitioned property from the CHIPS (Cookies Having Independent Partitioned State) spec. to avoid users having to fall back to the extensions property.
Both Chrome and Safari have indicated their support.
Describe the solution you'd like
A true or false property on CookieBuilder much like SameSite has today.
If the Paritioned property is set to true the cookie should be emitted with
Partitioned;
Set-Cookie: Beans=baked; SameSite=None; Secure; HttpOnly; Path=/; Partitioned;
The Partioned attribute can only be used with a Secure attribute, and the spec says browsers MUST reject a partitioned cookie if Secure is not present, so the builder could throw an exception on build.
A cookie that does not have SameSite=None but is partitioned really isn't partitioned at all, it's not going to be seen by third parties, but in that case the spec says Browsers MAY, so a debug message may be useful in that circumstance to help users track down that mistake.
Additional context
No response
The text was updated successfully, but these errors were encountered: