Skip to content

[Helix] Reenable music store E2E tests #8343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HaoK opened this issue Mar 8, 2019 · 4 comments
Closed

[Helix] Reenable music store E2E tests #8343

HaoK opened this issue Mar 8, 2019 · 4 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates task test-failure
Milestone
Backlog

Comments

@HaoK
Copy link
Member

HaoK commented Mar 8, 2019

Need to reenable these tests on helix
This was referenced Mar 8, 2019
Closed
Closed
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview4 milestone Mar 8, 2019
@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 8, 2019
@HaoK HaoK mentioned this issue Mar 13, 2019
Closed
@natemcmaster
Copy link
Contributor

These tests are also affected by #10268

natemcmaster added a commit to natemcmaster/AspNetCore that referenced this issue May 21, 2019
@natemcmaster
Workaround dotnet#8343
59430d8
@natemcmaster natemcmaster mentioned this issue May 21, 2019
Merged
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview8, Backlog Jun 25, 2019
@halter73
Copy link
Member

@HaoK It looks like music store tests are now running on Helix. Should we close this?

@HaoK
Copy link
Member Author

HaoK commented May 20, 2020

I think the E2E ones are still disabled, see

aspnetcore/src/MusicStore/test/MusicStore.E2ETests/MusicStore.E2ETests.csproj

Line 12 in 5af0c47

<BuildHelixPayload>false</BuildHelixPayload>

@HaoK
Copy link
Member Author

HaoK commented Dec 16, 2020

Music store has been deleted, closing as this no longer applies

@HaoK HaoK closed this as completed Dec 16, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates task test-failure
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@halter73 @pranavkm @natemcmaster @HaoK @mkArtakMSFT