HTTP2: Fix HttpRequestHeaders no longer being pooled #19329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
|
I opened #19312 already, but this looks a bit more complete. |
jkotalik
approved these changes
Feb 25, 2020
gfoidl
reviewed
Feb 25, 2020
| @@ -6105,7 +6105,7 @@ public unsafe void Append(ReadOnlySpan<byte> name, ReadOnlySpan<byte> value) | |||
| } | |||
|
|
|||
| // We didn't have a previous matching header value, or have already added a header, so get the string for this value. | |||
| var valueStr = value.GetRequestHeaderStringNonNullCharacters(_useLatin1); | |||
| var valueStr = value.GetRequestHeaderStringNonNullCharacters(UseLatin1); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
halter73
approved these changes
Feb 25, 2020
|
This change (in addition to the one already committed) will make it in 3.1.3 correct? |
|
No. This was a regression to new functionality on master when the 3.1.3 branch was merged back. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpRequestHeaders is showing up in profile:
I believe there was a regression caused when Latin1 headers #18255 was merged with Justin's stream pooling changes.