Remove extra abstract keyword #24274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks @Youssef1313 ! |
HaoK
approved these changes
Jul 27, 2020
|
The root issue is in scaffolding if you are scaffolding, the changes to the UI files don't affect what gets scaffolded, so it actually doesn't really matter whether this class is abstract or not in the UI sources |
|
Oh I see what you are saying, scaffolding is the workaround |
|
This file doesn't exist in 3.1 as we removed it to bring the feature back in 5.0, so I don't think we are likely going to be fixing it for 3.1, but the feature should work in 5.0 https://github.com/dotnet/aspnetcore/tree/release/3.1/src/Identity/UI/src/Areas/Identity/Pages/V4/Account (note there is no ResendEmailConfirmation.cshtml file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed in dotnet/Scaffolding#1339
Shouldn't it be removed here too? or I'm missing something?
Not sure if this fixes issue #24273 or not