Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api baselines #25386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api baselines #25386
Changes from all commits
3668c22
28bc63f
0e804eb
956b843
51d419a
f5b83b9
83a2dee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mavasani Regarding this, how much does it matter whether we've actually started annotating these libraries here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcouv would be a better person to answer this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the lack of errors about this, I suggest we include
#nullable enable
everywhere. Makes life simpler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougbu Pretty sure this project has public API, but the analyzer isn't running on it. Thoughts on why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specifically include only projects with
'$(IsImplementationProject)' == 'true'
and that excludes analyzer projects. From a compatibility POV, adding or removingpublic
surface in these projects shouldn't matter. So, these files can be removed.Side note: I also excluded all projects in the src/Tools/ directory (well, anything w/ a relative path that includes "Tools") for similar reasons. Might need to exclude
msbuild
tasks too (for the Razor SDK) but I didn't get there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I wasn't sure whether the analyzers folder contained anything w/ important public API e.g. a base package when I wrote up #24347. Sorry.