Add Public API baselines for Razor #25637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-infrastructure
Pilchie
commented
Sep 4, 2020
src/Razor/Microsoft.AspNetCore.Razor.Tools/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
src/Razor/perf/Microsoft.AspNetCore.Razor.Performance/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
dougbu
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Suspect some of the other projects here are tasks and tools that need no API baselines. I'd wait for @pranavkm or @SteveSandersonMS
src/Razor/Microsoft.AspNetCore.Razor.Tools/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
src/Razor/perf/Microsoft.AspNetCore.Razor.Performance/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
|
Part of #24347 |
Pilchie
force-pushed
the
api-baselines-razor
branch
from
9cede09 to
dc41083
Compare
pranavkm
reviewed
Sep 9, 2020
| @@ -0,0 +1,26 @@ | |||
| #nullable enable | |||
There was a problem hiding this comment.
Does this mean this project has nullable enabled (because I don't think it does): https://github.com/dotnet/aspnetcore/blob/master/src/Razor/Microsoft.CodeAnalysis.Razor/src/Microsoft.CodeAnalysis.Razor.csproj#L3-L9
There was a problem hiding this comment.
No, means the analyzer will handle nullable annotations if they exist in the assembly
pranavkm
approved these changes
Sep 10, 2020
Pilchie
added
the
tell-mode
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.