-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add micro-benchmark validation #29695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd rather fix the folder structure than make validation opt-in. BenchmarkDotNet hasn't release a package in a while now. Can we use the nightly package feed for our microbenchmarks? |
Yeah, I asked and they should be releasing an update in a week or two |
I like the current format for SignalR and Middleware: Which would make Kestrel: |
Sounds good to me. @sebastienros We're planning to move and rename the Microsoft.AspNetCore.Server.Kestrel.Performance microbenchmarks. This is just a heads up in case you need to react. |
c4ccb7f
to
5e0967e
Compare
I will update our config files when it's merged, and maybe get them running in the perf CI. |
55c34ed
to
742f4b2
Compare
c95e054
to
a80abca
Compare
src/SignalR/perf/Microbenchmarks/HubConnectionReceiveBenchmark.cs
Outdated
Show resolved
Hide resolved
src/SignalR/perf/Microbenchmarks/HubConnectionReceiveBenchmark.cs
Outdated
Show resolved
Hide resolved
Any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Fixes #27607
Fixes #23025
Open question:
Should projects have to opt-in for validation? If not, we need to align on a folder/project name structure so we don't try to validate non-micro benchmark projects.
This is currently turned off because BenchmarkDotNet hasn't released a package that works with net6.0 yet. Using nightlies I can verify this locally.
On failure: