Skip to content

Warn that TokenValidated is not the last step of validation #32299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021

Conversation

Tratcher
Copy link
Member

Forward port of aspnet/AspNetKatana#412.
Users have been confused by TokenValidated, thinking it indicated that all authentication is finished. In fact it only refers to one step of the validation, the token itself. Adding a clarifying comment.

@Tratcher Tratcher added this to the 6.0-preview5 milestone Apr 30, 2021
@Tratcher Tratcher requested a review from blowdart April 30, 2021 17:42
@Tratcher Tratcher self-assigned this Apr 30, 2021
@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Apr 30, 2021
@Tratcher Tratcher merged commit bf6c1c4 into dotnet:main May 7, 2021
@Tratcher Tratcher deleted the tratcher/warn branch May 7, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants