Skip to content

SimpleTypeModelBinder.CheckModel: add API doc #39982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

yecril71pl
Copy link
Contributor

@yecril71pl yecril71pl commented Feb 4, 2022

SimpleTypeModelBinder.CheckModel: add API doc

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

There is no documentation to inherit from, so specific documentation must be provided.

Having this interface documented would allow me to do the following trick:

protected override
void CheckModel (ModelBindingContext ctx, ValueProviderResult r, object? m)
 { if (m is string v) ctx .Result = ModelBindingResult .Success (v .Trim ()); }

There is no documentation to inherit from.
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Feb 4, 2022
@pranavkm pranavkm merged commit 4d8ec54 into dotnet:main Feb 4, 2022
@ghost ghost added this to the 7.0-preview2 milestone Feb 4, 2022
@yecril71pl yecril71pl deleted the patch-3 branch February 7, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants