Skip to content

Avoid request body rate timeout in flaky test #39999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Feb 4, 2022

GET_GracefulServerShutdown_AbortRequestsAfterHostTimeout is testing the behavior of shutdown timeouts, not rate timeouts.

[6.098s] [Microsoft.AspNetCore.Server.Kestrel.BadRequests] [Debug] Connection id "0HMF7DR9L1H02", Request id "null": the request timed out because it was not sent by the client at a minimum of 240 bytes/second.

[7.351s] [Microsoft.AspNetCore.Server.Kestrel] [Warning] As of "02/03/2022 23:42:38 +00:00", the heartbeat has been running for "00:00:01.2496930" which is longer than "00:00:01". This could be caused by thread pool starvation.

Even though the Http3ReuestsTests sets the ShutdownTimeout to 1 second instead of the 5 second default, it looks like timer didn't fire fast enough due to likely threadpool starvation. If the threadpool starvation is bad enough, even this won't help, but this should give more time for the threadpool to work the queue of work items.

Addresses #39985

GET_GracefulServerShutdown_AbortRequestsAfterHostTimeout is testing the
behavior of shutdown timeouts not rate timeouts.
@halter73 halter73 enabled auto-merge (squash) February 4, 2022 23:18
@halter73 halter73 merged commit c8c3b7c into main Feb 5, 2022
@halter73 halter73 deleted the halter73/39985 branch February 5, 2022 00:43
@ghost ghost added this to the 7.0-preview2 milestone Feb 5, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants