Remove support for setting default scheme from user-jwts #42578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
added
old-area-web-frameworks-do-not-use
captainsafia
requested review from
Tratcher,
BrennanConroy,
halter73 and
Pilchie
as code owners
Tratcher
approved these changes
Jul 5, 2022
src/Tools/dotnet-user-jwts/src/Helpers/JwtAuthenticationSchemeSettings.cs
Outdated
Show resolved
Hide resolved
…Settings.cs Co-authored-by: Chris Ross <Tratcher@Outlook.com>
| @@ -14,7 +14,6 @@ namespace Microsoft.AspNetCore.Authentication; | |||
| public class AuthenticationService : IAuthenticationService | |||
| { | |||
| private HashSet<ClaimsPrincipal>? _transformCache; | |||
| private const string defaultSchemesOptionsMsg = "The default schemes can be set using either AddAuthentication(string defaultScheme) or AddAuthentication(Action<AuthenticationOptions> configureOptions) or by setting the Authentication:DefaultScheme property in configuration."; | |||
There was a problem hiding this comment.
Aww, this was a nice change
BrennanConroy
approved these changes
Jul 5, 2022
ghost
added this to the
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42481.
Superseded by #42497.