Skip to content

[release/7.0-rc1] Make Microsoft.AspNetCore.Grpc.Swagger experimental #43384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 19, 2022

Fixes #43294

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Aug 19, 2022
@JamesNK JamesNK requested a review from dougbu August 19, 2022 05:50
@JamesNK JamesNK requested a review from captainsafia as a code owner August 19, 2022 05:50
@dougbu
Copy link
Contributor

dougbu commented Aug 19, 2022

Versioning was as expected in previous CI build. The packages (-symbols too) were created and only in the wrong category.
image

@JamesNK
Copy link
Member Author

JamesNK commented Aug 20, 2022

@adityamandaleeka I'd like to publish this package as an experiment along with aspnetcore release.

The package already exists - https://www.nuget.org/packages/Microsoft.AspNetCore.Grpc.Swagger - it was previously published as an experiment from the aspnet/asplabs repo.

Copy link
Member

@adityamandaleeka adityamandaleeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is a preview package and we're moving the source across repos and making some changes.

@adityamandaleeka adityamandaleeka merged commit 95a8f92 into release/7.0-rc1 Aug 22, 2022
@adityamandaleeka adityamandaleeka deleted the jamesnk/grpc-swagger-experimental branch August 22, 2022 23:20
halter73 pushed a commit to halter73/AspNetCore that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants