Retry a few tests #43422
Merged
Retry a few tests #43422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Aug 20, 2022
dougbu
commented
- looks like general flakiness of a couple of test classes
- looks like general flakiness of a couple of test classes
ghost
added
the
area-infrastructure
|
@BrennanConroy my suggestion in https://github.com/dotnet/aspnetcore/pull/43410/files#r950633459 won't help much after this is merged since the test I added is in |
dougbu
commented
Aug 20, 2022
| @@ -7,6 +7,9 @@ | |||
| {"testName": {"contains": "MaxRequestBufferSizeTests.LargeUpload" }}, | |||
| {"testName": {"contains": "ReaderThrowsResetExceptionOnInvalidBody" }}, | |||
| {"testName": {"contains": "AttributeRouting_RouteNameTokenReplace_Reachable" }}, | |||
| {"testName": {"contains": "Http3RequestTests"}}, | |||
| {"testName": {"contains": "Http3TlsTests"}}, | |||
| {"testName": {"contains": "StreamPool_StreamAbortedOnClientAndServer_NotPooled"}}, | |||
| {"testName": {"contains": "ServerCertificateSelector_Invoked"}}, | |||
There was a problem hiding this comment.
This test is in Http3TlsTests but I'm not removing it because it may be flaky for more specific reasons e.g. we might remove the class from here and immediately need to add the specific test back
dougbu
commented
Aug 21, 2022
Comment on lines
+10
to
+11
| {"testName": {"contains": "Http3RequestTests"}}, | ||
| {"testName": {"contains": "Http3TlsTests"}}, |
wtgodbe
approved these changes
Aug 22, 2022
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/3147732196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.