[Blazor] Fix linking issues #43515
Merged
[Blazor] Fix linking issues #43515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TanayParikh
approved these changes
Aug 25, 2022
javiercn
force-pushed
the
javiercn/fix-linking-config
branch
from
4c00d1d to
e33a47e
Compare
javiercn
requested review from
a team,
dougbu,
wtgodbe,
BrennanConroy,
halter73,
Tratcher,
JamesNK,
captainsafia,
mkArtakMSFT and
Pilchie
as code owners
javiercn
removed request for
a team,
halter73,
JamesNK,
Pilchie,
Tratcher,
captainsafia,
dougbu,
BrennanConroy,
wtgodbe and
mkArtakMSFT
javiercn
force-pushed
the
javiercn/fix-linking-config
branch
from
e33a47e to
645ff16
Compare
javiercn
commented
Aug 25, 2022
...omponents/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs
Outdated
Show resolved
Hide resolved
…ices/RemoteAuthenticationService.cs Remove additional whitespace
Quarantining for now akes sense to me @captainsafia |
I quarantined in #43478, you could wait for that to flow up to |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/3153432703 |
10 tasks
1 task
mkArtakMSFT
pushed a commit
that referenced
this pull request
Oct 3, 2022
Backport of #43515 to release/7.0 /cc @MackinnonBuck @javiercn # Fix linking issues Fixes an issue reported by manual testing where Blazor WebAssembly projects created from the Individual Auth template throw an exception on page load after publishing. ## Description The problem was already fixed in `main` by making `RemoteAuthenticationService` more linker friendly. From @javiercn's comment on the original issue: > What was happening was that the linker was erasing the parameter names of the record we were using for serializing the data Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/1556 ## Customer Impact Customers are likely to encounter this issue, especially since one of our project templates reproduces the bug. It's expected that our project templates should be ready to publish out of the box. ## Regression? - [X] Yes - [ ] No Regressed from .NET 6. ## Risk - [ ] High - [ ] Medium - [X] Low The change only involves minor restructuring to enable linker-friendliness. There are no changes to any core functionality. ## Verification - [X] Manual (required) - [ ] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/aspnet/AspNetCore-ManualTests/issues/1556
Even though the report claims that it does not reproduce after the latest SDK insertion, it is still valuable to be more explicit about the linking.