-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Update Microsoft.Web.Xdt version #43521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NikolaMilosavljevic I enabled auto-merge because I doubt you have rights to merge into release/7.0 |
@dougbu one test is failing - do you if this is a known issue? Helix log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-43521-merge-2943ef4d444443beb1/Interop.FunctionalTests--net7.0/1/console.eb323cc8.log?helixlogtype=result
|
Probably test flakiness - CC @halter73 who's on build ops |
|
I'm OOF. My bad for not checking beforehand. @captainsafia has graciously swapped with me. |
@captainsafia we should probably just |
Should we wait on merging this PR, until the test is fixed or skipping enabled? My changes are unrelated, and can be merged, I believe. |
@dougbu is the fix for the test in release/7.0 branch? I could close and reopen this PR to pick up the fix. Alternatively, this PR could be merged now, as the known failure is not introduced by my changes. |
@NikolaMilosavljevic I think we can save the extra build here and merge this PR as is considering the failure is unrelated. @dougbu If that's fine with you, I'll use my temporary admin privileges to merge. |
Had to disable auto-merge first 😁 |
Update Microsoft.Web.Xdt version
Description
Updates version of Microsoft.Web.Xdt package and add source-build dependency in Version.Details.xml.
Fixes dotnet/source-build#2969