Skip to content

Update Microsoft.Web.Xdt version #43521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

NikolaMilosavljevic
Copy link
Member

Update Microsoft.Web.Xdt version

Description

Updates version of Microsoft.Web.Xdt package and add source-build dependency in Version.Details.xml.

Fixes dotnet/source-build#2969

@NikolaMilosavljevic NikolaMilosavljevic requested review from a team, dougbu and wtgodbe as code owners August 24, 2022 16:39
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 24, 2022
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 24, 2022
@dougbu
Copy link
Contributor

dougbu commented Aug 24, 2022

@NikolaMilosavljevic I enabled auto-merge because I doubt you have rights to merge into release/7.0

@dougbu dougbu enabled auto-merge (squash) August 24, 2022 17:27
@NikolaMilosavljevic
Copy link
Member Author

@dougbu one test is failing - do you if this is a known issue? Helix log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-43521-merge-2943ef4d444443beb1/Interop.FunctionalTests--net7.0/1/console.eb323cc8.log?helixlogtype=result

2022-08-25T00:23:19.9102105Z [xUnit.net 00:00:29.04]       Assert.Throws() Failure
2022-08-25T00:23:19.9117637Z [xUnit.net 00:00:29.03]     Interop.FunctionalTests.Http3.Http3TlsTests.OnAuthenticate_Available_Throws(protocols: Http1AndHttp2AndHttp3) [FAIL]
2022-08-25T00:23:19.9138337Z [xUnit.net 00:00:29.04]       Expected: typeof(System.NotSupportedException)
2022-08-25T00:23:19.9185721Z [xUnit.net 00:00:29.04]       Actual:   typeof(System.IO.IOException): Failed to bind to address https://0.0.0.0:48668: address already in use.
2022-08-25T00:23:19.9217384Z [xUnit.net 00:00:29.05]       ---- System.IO.IOException : Failed to bind to address https://0.0.0.0:48668: address already in use.
2022-08-25T00:23:19.9686149Z [xUnit.net 00:00:29.05]       -------- Microsoft.AspNetCore.Connections.AddressInUseException : Address already in use
2022-08-25T00:23:19.9686431Z [xUnit.net 00:00:29.05]       ------------ System.Net.Sockets.SocketException : Address already in use

@wtgodbe
Copy link
Member

wtgodbe commented Aug 25, 2022

Probably test flakiness - CC @halter73 who's on build ops

@dougbu
Copy link
Contributor

dougbu commented Aug 25, 2022

This is a test problem @JamesNK's fixes in RC1 might not have fixed. In fact it's worse these days.

Could backport a7fa969 from 'main' to cover all Http3TlsTests.

@dougbu
Copy link
Contributor

dougbu commented Aug 25, 2022

Oh, that's not quite right. #43534 will include the fixes @JamesNK did in RC1. Not sure what's holding that PR up…

@dougbu
Copy link
Contributor

dougbu commented Aug 25, 2022

☹️ Helix tests failing there too ☹️ (not just expected Code Check errors)

@halter73
Copy link
Member

Probably test flakiness - CC @halter73 who's on build ops

I'm OOF. My bad for not checking beforehand. @captainsafia has graciously swapped with me.

@dougbu
Copy link
Contributor

dougbu commented Aug 25, 2022

@captainsafia we should probably just Skip="borked" that particular test. I see some evidence it fails even in main, where we retry all Http3TlsTests tests.

@dougbu
Copy link
Contributor

dougbu commented Aug 25, 2022

This is our worst offender among all tests these days (across most branches)
image

@NikolaMilosavljevic
Copy link
Member Author

@captainsafia we should probably just Skip="borked" that particular test. I see some evidence it fails even in main, where we retry all Http3TlsTests tests.

Should we wait on merging this PR, until the test is fixed or skipping enabled? My changes are unrelated, and can be merged, I believe.

@NikolaMilosavljevic
Copy link
Member Author

@dougbu is the fix for the test in release/7.0 branch? I could close and reopen this PR to pick up the fix.

Alternatively, this PR could be merged now, as the known failure is not introduced by my changes.

@captainsafia
Copy link
Member

@NikolaMilosavljevic I think we can save the extra build here and merge this PR as is considering the failure is unrelated.

@dougbu If that's fine with you, I'll use my temporary admin privileges to merge.

@dougbu dougbu disabled auto-merge August 26, 2022 18:35
@dougbu dougbu merged commit 662fa48 into dotnet:release/7.0 Aug 26, 2022
@dougbu
Copy link
Contributor

dougbu commented Aug 26, 2022

Had to disable auto-merge first 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants