Skip to content

Add RequestDelegate analyzer #44048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Add RequestDelegate analyzer #44048

merged 1 commit into from
Sep 27, 2022

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 19, 2022

Fixes #42523

Add an analyzer that detects when a method or lambda is used to create a RequestDelegate.

@JamesNK JamesNK requested review from a team, dougbu, wtgodbe and Pilchie as code owners September 19, 2022 11:44
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 19, 2022
@JamesNK JamesNK force-pushed the jamesnk/requestdelegate-analyzer branch from 02b2ee0 to 65db902 Compare September 22, 2022 03:07
@JamesNK JamesNK force-pushed the jamesnk/requestdelegate-analyzer branch from 65db902 to aa1174a Compare September 26, 2022 13:01
@captainsafia
Copy link
Member

@JamesNK Did you intend to merge both analyzers into a single PR here?

@JamesNK JamesNK force-pushed the jamesnk/requestdelegate-analyzer branch from aa1174a to 539e461 Compare September 27, 2022 00:46
@JamesNK
Copy link
Member Author

JamesNK commented Sep 27, 2022

@JamesNK Did you intend to merge both analyzers into a single PR here?

Yes. Other PR is merged, rebased this one.

@JamesNK JamesNK merged commit 00e49a6 into main Sep 27, 2022
@JamesNK JamesNK deleted the jamesnk/requestdelegate-analyzer branch September 27, 2022 22:08
@ghost ghost added this to the 8.0-preview1 milestone Sep 27, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyzer: Detect using Task<T> with RequestDelegate
3 participants