Move SignalR connection start telemetry to transport start #48753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halter73 With this PR's changes, the metrics, event counter, and duration measurement for a "started connection" are consistent. |
JamesNK
force-pushed
the
jamesnk/counter-rename-part2
branch
from
4e433ef to
155c0db
Compare
BrennanConroy
approved these changes
Jun 13, 2023
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
Outdated
Show resolved
Hide resolved
…nManager.cs Co-authored-by: Brennan <brecon@microsoft.com>
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes when SignalR connection start telemetry to the point where the connection's transport starts.
Telemetry includes:
Follow up to #48375