Better implementation of EventCallback.Equals #53395
Conversation
dotnet-issue-labeler
bot
added
the
area-blazor
ghost
added
the
community-contribution
|
Thanks for your PR, @JelleHissink. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Thanks @JelleHissink! Since this change will cause some components to re-render less often (which is a good thing), it would be ideal to also have an E2E test showing a case where a re-render is avoided by this change, and perhaps another showing that it is still possible to change an event handler to force a re-render. I appreciate it's not obvious how to do that and you might not wish to take it on, so this is something we can add if you prefer. |
|
I did not manage to get the whole testsuite running on my machine. If there is somebody else who could take this on that would be great. |
ghost
added
the
pending-ci-rerun
| @@ -80,5 +80,5 @@ public override int GetHashCode() | |||
| public override bool Equals(object? obj) | |||
| => obj is EventCallback other | |||
| && ReferenceEquals(Receiver, other.Receiver) | |||
| && ReferenceEquals(Delegate, other.Delegate); | |||
| && (Delegate?.Equals(other.Delegate) ?? (other.Delegate == null)); | |||
There was a problem hiding this comment.
object.Equals(a, b) performs null handling and delegates to a.Equals(b).
wtgodbe
removed
the
pending-ci-rerun
dotnet-policy-service
bot
added
the
area-infrastructure
wtgodbe
removed
the
area-infrastructure
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
/azp run |
dotnet-policy-service
bot
removed
the
pending-ci-rerun
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run aspnetcore-quarantined-pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
javiercn
added
the
pending-merge
|
Thanks for picking this up! |
We noticed after upgrading our blazor application to .net 8.0 that some EventCallback keep being modified. Eventhough the value was the same, the same target component, the same method.
The generated code that renders the component seems to fabricate a new MulticastDelegate, having the same Type, Target and Method. The implementation of EventCallback uses Object.ReferenceEquals, so it concludes it is different every render.
Fixes #53361
NOTE
I recreated this because I have some difficulties changing the pr to go to main (#53362)