Update .NET SDK to 9.0.100-alpha.1.24070.3 #53525
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Update .NET SDK to version 9.0.100-alpha.1.24070.3. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
@wtgodbe Is there a way to configure this action to update a previous PR? Or wait for the previous PR to be merged before opening a new one? |
|
It should already do that itself via the default |
|
Actually, that's not what you asked for - it would do the opposite. It would generate a new one and close the previous. |
|
If you configured it to use a fixed well-known branch name, then you'd get the behaviour you wanted, where it would only generate a new PR if the branch didn't currently exist. That relies on branches being cleaned-up post-merge. Doing the opposite of the current behaviour (which I'm not sure without debugging, why this one didn't close #53449) or updating an existing PR in place would need adding as a feature. |
I had a quick look into this, and couldn't see an obvious reason why this didn't happen (this is the relevant code). Maybe some sort of timing/indexing issue with the GitHub API results at the time it ran? |
|
I am going to merge the previous one for now since it passed. Then I'll unblock this one. |
|
I tried triggering the workflow again, let's see if it closes this |
|
That created #53600 & didn't close this. Maybe it's important whether the worflow was manually triggered or triggered by automation? It's only run on the automated schedule 1 time, for this PR. |
|
I'll have to have another look at why to might be failing to find the old PRs when it opens a new one. I wonder if this size of this repo (number of issues/PRs etc) compared to the ones where I've seen the auto-close functionality work fine is causing some sort of timing issue that means some sort of eventual consistency in the GitHub API is noticeable enough for it to not work correctly for what the code does. |
|
@wtgodbe Could you try manually running it again, but with debugging enabled? It might give me some output that gives a clue as to what's happening. |
|
@martincostello I set the |
|
I don't see any of the purple debug output (like this). I think you need to re-run it with the checkbox ticked (after closing the PR it opened and deleting the branch):
|
Done. Weird, I don't see that checkbox when just queuing a new job, only on retry. |
|
Thanks 👍 - I'll have a dig though and see if I can work out what's going on. |
Thanks, I really appreciate it! |
|
#53603 should sort it - the logic to use it was incorrectly behind an |
|
Close it since this one should get in? |
Updates the .NET SDK to version
9.0.100-alpha.1.24070.3, which also updates the .NET runtime from version9.0.0-alpha.1.24057.2to version9.0.0-alpha.1.24066.33.This pull request was auto-generated by GitHub Actions.