-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Provide Microsoft.Extensions.Http.Polly
package README
#57771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @martincostello Do have any thoughts?
The document looks fine to me as-is. One thought I had thought I had though was maybe it would be worth a comment encouraging people to use to the new resilience libraries from dotnet/extensions that use the new Polly.Core APIs? There have been a few issues where people have asked when this package will be updated to use Polly v8 and I've had to explain the sort-of fork that's happened and that this package is kinda frozen and the new innovation is in the new extensions package. |
Co-authored-by: Stephen Halter <halter73@gmail.com>
That's a good idea. I've updated the README to include such a note. Some of our docs even go as far as to say that |
Maybe for .NET 10? It's a non-trivial piece of work to swap from one to the other, so at this stage it would be a bit of annoying rug-pull for users. |
Co-authored-by: Stephen Halter <halter73@gmail.com>
Co-authored-by: Stephen Halter <halter73@gmail.com>
Contributes to #48392