Skip to content

Provide Microsoft.Extensions.Http.Polly package README #57771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

MackinnonBuck
Copy link
Member

Contributes to #48392

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 9, 2024
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @martincostello Do have any thoughts?

@martincostello
Copy link
Member

Do have any thoughts?

The document looks fine to me as-is.

One thought I had thought I had though was maybe it would be worth a comment encouraging people to use to the new resilience libraries from dotnet/extensions that use the new Polly.Core APIs? There have been a few issues where people have asked when this package will be updated to use Polly v8 and I've had to explain the sort-of fork that's happened and that this package is kinda frozen and the new innovation is in the new extensions package.

MackinnonBuck and others added 2 commits September 10, 2024 10:53
@MackinnonBuck
Copy link
Member Author

One thought I had thought I had though was maybe it would be worth a comment encouraging people to use to the new resilience libraries from dotnet/extensions that use the new Polly.Core APIs?

That's a good idea. I've updated the README to include such a note. Some of our docs even go as far as to say that Microsoft.Extensions.Http.Polly is deprecated, although the ASP.NET Core docs don't mention this, and we're still shipping new versions. Maybe we should consider not shipping new versions of this package (and updating the ASP.NET Core docs).

@martincostello
Copy link
Member

Maybe we should consider not shipping new versions of this package (and updating the ASP.NET Core docs).

Maybe for .NET 10? It's a non-trivial piece of work to swap from one to the other, so at this stage it would be a bit of annoying rug-pull for users.

@MackinnonBuck MackinnonBuck merged commit dd01c93 into main Sep 11, 2024
23 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/readme-http-polly branch September 11, 2024 20:29
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Sep 11, 2024
@MackinnonBuck MackinnonBuck mentioned this pull request Sep 12, 2024
1 task
captainsafia pushed a commit that referenced this pull request Dec 31, 2024
Co-authored-by: Stephen Halter <halter73@gmail.com>
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
Co-authored-by: Stephen Halter <halter73@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants