Support resolving OpenAPI server URLs from HttpRequest #60617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/OpenApi/src/Services/OpenApiDocumentService.cs:223
- Returning an empty collection using square brackets is invalid in C#. Replace with a valid initializer, for example: return new List();
return [];
...NetCore.OpenApi.Tests/Services/OpenApiDocumentService/OpenApiDocumentServiceTests.Servers.cs
Show resolved
Hide resolved
captainsafia
added
area-mvc
DeagleGross
approved these changes
Feb 27, 2025
captainsafia
added a commit
that referenced
this pull request
Feb 28, 2025
* Support resolving OpenAPI server URLs from HttpRequest * Try passing optional params everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57332.
I was previously squeamish about introducing a dependency on
HttpRequestinOpenApiDocumentService.GetOpenApiDocumentAsyncbecause it ends up being called from the build-time generation codepath but considering some ideas I have in that space I think it's fine for us to introduce a dependency on the HttpRequest for this codepath.I've retained the codepath that uses the ServerAddressFeature for back-compat in the case that an HttpContext is not available.
Note: this is a backport candidate.