Skip to content

Only build BuildAfterTargeting pack on win-x64 #60658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Only build BuildAfterTargeting pack on win-x64 #60658

merged 4 commits into from
Feb 28, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 27, 2025

Fixes #60530. This project just produces some .nupkg's, and doesn't build anything for the sharedFx/Ref pack. We can be certain that it never will, because by definition it builds after the targeting pack.

BuildAfterTargetingPack.csproj introduces flakiness into the build because it sometimes causes a race condition that leads to file conflicts - therefore we should build it as infrequently as possible (only on win-x64).

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2652111&view=results

@Copilot Copilot AI review requested due to automatic review settings February 27, 2025 22:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 27, 2025
@wtgodbe wtgodbe requested a review from Copilot February 27, 2025 23:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@wtgodbe wtgodbe changed the title Only build BuildAfterTargeting pack on win-x64 in VMR Only build BuildAfterTargeting pack on win-x64 Feb 27, 2025
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 28, 2025

There was a publishing failure in the VMR build - I don't think it's related, but not sure. Waiting to hear back from some VMR folks

Edit: The failure is unrelated

@wtgodbe wtgodbe requested a review from a team February 28, 2025 00:50
@ViktorHofer
Copy link
Member

What packages does this produce? In the VMR, we prefer every vertical to produce rid agnostic packages as upstream consumers might depend on it.

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 28, 2025

What packages does this produce? In the VMR, we prefer every vertical to produce rid agnostic packages as upstream consumers might depend on it.

Microsoft.AspNetCore.Grpc.JsonTranscoding & Microsoft.AspNetCore.Grpc.Swagger are the two shipping packages produced by this project (they have to build after the targeting pack because they use Swashbuckle.AspNetCore, which has a FrameworkReference to Microsoft.Aspnetcore.App in order to resolve Microsoft.Aspnetcore.Routing)

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 28, 2025

Did you double check that none of these packages are used in upstream repos like sdk? This change feels like a workaround to a build infrastructure issue to me but if diagnosing the actual issue isn't feasible or wouldn't help short-term, I'm fine with it as-is.

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 28, 2025

Did you double check that none of these packages are used in upstream repos like sdk? This change feels like a workaround to a build infrastructure issue to me but if diagnosing the actual issue isn't feasible or wouldn't help short-term, I'm fine with it as-is.

Yeah, the gRPC packages are not referenced by SDK. I agree this is a hack, but I'm bothered enough by the build reliability hit that I think it warrants doing something in the short term. Long-term I want to get rid of all of our custom reference resolution stuff, which should improve issues like this one

@wtgodbe wtgodbe merged commit af3875a into main Feb 28, 2025
27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/BTargx64 branch February 28, 2025 17:00
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rarely build BuildAfterTargetingPack.csproj
2 participants