1es-ify Localization pipeline #60720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
There was a problem hiding this comment.
PR Overview
This PR modernizes the localization pipeline by updating the YAML configuration to use official 1ES pipeline templates and a dedicated repository for pipeline assets. Key changes include:
- Updating template references from the legacy paths to the official ones.
- Adding a resources section to reference the 1ES pipeline repository.
- Extending the pipeline with a new official pipeline template that specifies Windows pool settings.
Reviewed Changes
| File | Description |
|---|---|
| .azure/pipelines/localization.yml | Updates to point to official 1ES templates and adds pipeline repository reference |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.azure/pipelines/localization.yml:28
- Verify that the '@self' repository reference is intended for the pool-providers template. Consider using the 1ES pipeline repository reference if consistency with the extended pipeline template is desired.
+- template: /eng/common/templates-official/variables/pool-providers.yml@self
.azure/pipelines/localization.yml:61
- Ensure that the use of '@self' for the onelocbuild job template is correct, as it may lead to inconsistent behavior if the intention was to pull from the 1ES pipeline repository.
+ - template: /eng/common/templates-official/job/onelocbuild.yml@self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loc pipeline has been broken for a long time because it was trying to run on a Linux agent. We should get it fully modernized by 1es-ifying it.
Test job here - we're currently at 99% localization coverage, so we can expect a small set of incoming changes, which we should consider backporting to 9.0: https://dev.azure.com/dnceng/internal/_build/results?buildId=2654452&view=results