Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal Cosmos provider code for NRTs #26558

Open
ajcvickers opened this issue Nov 5, 2021 · 3 comments
Open

Update internal Cosmos provider code for NRTs #26558

ajcvickers opened this issue Nov 5, 2021 · 3 comments
Assignees
@maumar
Labels
area-cosmos area-query type-enhancement
Milestone
MQ

Comments

@ajcvickers
Copy link
Contributor

ajcvickers commented Nov 5, 2021 •
edited
Loading

For example, some properties of SelectExpression in the Cosmos provider are marked as non-nullable, but are used as nullable in the code:

  • Limit
  • Offset
  • Predicate
@roji
Copy link
Member

roji commented Nov 5, 2021

IIRC most of Cosmos query internals isn't NRT-annotated (there's lots of #nullable disable there) because it's going to be redone anyway... /cc @smitpatel

@ajcvickers
Copy link
Contributor Author

@roji Is this tracked somewhere?

@smitpatel smitpatel self-assigned this Nov 5, 2021
@ajcvickers ajcvickers changed the title Cosmos: NRT issues Update internal Cosmos provider code for NRTs Nov 5, 2021
@ajcvickers ajcvickers added this to the 7.0.0 milestone Nov 5, 2021
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Apr 23, 2022
@smitpatel smitpatel removed their assignment Sep 14, 2022
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Oct 19, 2022
@ajcvickers ajcvickers mentioned this issue Feb 8, 2024
Closed
roji added a commit to roji/efcore that referenced this issue Apr 21, 2024
@roji
Annotate most of the Cosmos query pipeline for NRTs
fa0973f 
Excludes shaper generation for now.

Part of dotnet#26558
@roji roji mentioned this issue Apr 21, 2024
Merged
@roji
Copy link
Member

roji commented Apr 21, 2024

The server-side parts of the query pipeline were annotated in #33584, leaving only the shaper generation.

roji added a commit that referenced this issue Apr 23, 2024
@roji
Annotate most of the Cosmos query pipeline for NRTs (#33584)
cbe3722 
Excludes shaper generation for now.

Part of #26558
@roji roji assigned ajcvickers and maumar and unassigned roji Jun 15, 2024
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-cosmos area-query type-enhancement
Projects
None yet
Milestone
MQ
Development

No branches or pull requests
6 participants
@ajcvickers @smitpatel @maumar @roji @cincuranet @AndriySvyryd