Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Discriminator_values_are_not_marked_as_unknown cannot be overwritten. #34517

Closed
mianculovici opened this issue Aug 23, 2024 · 0 comments
Closed

Task Discriminator_values_are_not_marked_as_unknown cannot be overwritten. #34517

mianculovici opened this issue Aug 23, 2024 · 0 comments
Labels
area-test customer-reported type-bug
Milestone
9.0.0

Comments

@mianculovici
Copy link
Contributor

Task Discriminator_values_are_not_marked_as_unknown from test/EFCore.Specification.Tests/GraphUpdates/GraphUpdatesTestBaseMiscellaneous.cs has not been declared as virtual and cannot be overwritten.

https://github.com/dotnet/efcore/blob/main/test/EFCore.Specification.Tests/GraphUpdates/GraphUpdatesTestBaseMiscellaneous.cs
mianculovici added a commit to ActianCorp/efcore that referenced this issue Aug 23, 2024
@mianculovici
Make Discriminator_values_are_not_marked_as_unknown virtual so that i…
ba37ef1 
…t can be overwritten. (dotnet#34517)
@mianculovici mianculovici mentioned this issue Aug 23, 2024
Merged
ajcvickers pushed a commit that referenced this issue Aug 26, 2024
@mianculovici
Make Discriminator_values_are_not_marked_as_unknown virtual (#34517) (#…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d403645 
…34520)
@ajcvickers ajcvickers added this to the 9.0.0-rc2 milestone Aug 26, 2024
@roji roji modified the milestones: 9.0.0-rc2, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test customer-reported type-bug
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @roji @mianculovici