Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cosmos alias management #34074

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Implement Cosmos alias management #34074

merged 1 commit into from
Jul 3, 2024

Conversation

roji
Copy link
Member

@roji roji commented Jun 24, 2024

NOTE: This PR is based on #34066, review the 2nd commit only.

  • The PR looks big, but is mostly NoSQL baseline changes for aliases (easy!)
  • Introduce CosmosAliasManager, same as relational's SqlAliasManager
  • Use the container name in the query instead of root (i.e. SELECT n from NorthwindContext n instead of SELECT c FROM root c).
  • Remove SelectExpression construction out to CosmosQueryableMethodTranslatingEV, removing IEntityType knowledge from SelectExpression (same as in relational)

@roji roji requested a review from a team June 24, 2024 08:04
@roji
Copy link
Member Author

roji commented Jun 24, 2024

Design discussion: revert the change to switch from root to the container name, since the container name may be long and we're not sure about special characters/escaping.

@roji roji requested review from AndriySvyryd and maumar as code owners June 25, 2024 08:24
@roji roji force-pushed the CosmosAliases branch 4 times, most recently from 46f4e3d to 48595d6 Compare July 2, 2024 06:32
@roji roji force-pushed the CosmosAliases branch from 48595d6 to 039b10c Compare July 3, 2024 21:36
@roji roji enabled auto-merge (squash) July 3, 2024 21:36
@roji roji merged commit f9878b9 into dotnet:main Jul 3, 2024
7 checks passed
@roji roji deleted the CosmosAliases branch July 3, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants