Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context options to control constantization/parameterization of parameterized collections and EF.Parameter improvement collection parameters #34406

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

cincuranet
Copy link
Contributor

Fixes #34344
Fixes #34345

@cincuranet cincuranet requested a review from roji August 12, 2024 09:49
@cincuranet
Copy link
Contributor Author

The naming is TBD.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, really only naming and some nits remaining...

@cincuranet cincuranet marked this pull request as ready for review August 13, 2024 08:17
@cincuranet cincuranet requested a review from roji August 13, 2024 08:17
@cincuranet
Copy link
Contributor Author

@roji This is now ready to review.

FYI I also included changes (HashSet -> ISet, etc.) related to this area from latest #33220.

@cincuranet cincuranet enabled auto-merge (squash) August 13, 2024 08:19
@roji roji self-assigned this Aug 13, 2024
@roji roji disabled auto-merge August 13, 2024 08:50
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last minor stuff.

@cincuranet cincuranet merged commit f1fee85 into dotnet:main Aug 13, 2024
7 checks passed
@cincuranet cincuranet deleted the const-param-options branch August 13, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants