Don't generate code for precached values in the compiled model by default #34412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
commented
Aug 13, 2024
AndriySvyryd
force-pushed
the
Issue33483
branch
2 times, most recently
from
2dcf94d to
c57f84c
Compare
roji
approved these changes
Aug 14, 2024
| /// Gets or sets a value indicating whether the generated code should be compatible with NativeAOT. | ||
| /// </summary> | ||
| /// <value> A value indicating whether the generated code should be compatible with NativeAOT. </value> | ||
| public virtual bool ForNativeAot { get; set; } |
There was a problem hiding this comment.
I think this is fine for 9.0, but if we indeed want to vary the behavior of --optimize for NativeAOT/non-NativeAOT, this ideally should be something we infer automatically from the csproj rather than force the user to explicitly specify the switch... Though that can get problematic if this is also needed for precompiled queries with NativeAOT, which AFAIK wouldn't have require any gesture in the csproj.
That's just SQL Server flakiness |
…ault Add --nativeaot CLI option to output the eager code
AndriySvyryd
force-pushed
the
Issue33483
branch
from
c57f84c to
f09c51f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --nativeaot CLI option to output the eager code
Part of #33483