Optimize MIN/MAX over DISTINCT #34699
Merged
+30
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranma42
force-pushed
the
optimize-distinct-minmax
branch
from
252e4f6 to
61a58a7
Compare
ranma42
commented
Sep 17, 2024
| SELECT DISTINCT [o].[OrderID] | ||
| FROM [Orders] AS [o] | ||
| ) AS [o0] | ||
| SELECT MAX([o].[OrderID]) |
There was a problem hiding this comment.
these tests seem to be aimed at checking exactly this behavior; should I add something similar or are they adequate?
roji
approved these changes
Sep 17, 2024
| SELECT DISTINCT [o].[OrderID] | ||
| FROM [Orders] AS [o] | ||
| ) AS [o0] | ||
| SELECT MAX([o].[OrderID]) |
| /// Drops DISTINCT operator on the selector of the <see cref="EnumerableExpression" />. | ||
| /// </summary> | ||
| /// <returns>The new expression with specified component updated.</returns> | ||
| public virtual EnumerableExpression DropDistinct() |
There was a problem hiding this comment.
nit: I'd rather have a single SetDistinct(bool) here (or similar) rather than two to keep the API surface tighter
ranma42
force-pushed
the
optimize-distinct-minmax
branch
from
61a58a7 to
6820eb6
Compare
Yes 👍
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a value is computed as MAX or MIN of a subquery, DISTINCT has no effect and can be removed.
Fixes #34483.