[release/9.0] Rename IncludeRootDiscriminatorInJsonId to HasRootDiscriminatorInJsonId #34717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @artl93 |
artl93
approved these changes
Sep 19, 2024
AndriySvyryd
approved these changes
Sep 19, 2024
|
@AndriySvyryd - please flow through tactics. We just met and I shouldn't have marked this approved. |
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
9.0 introduced two new APIs for Cosmos: IncludeDiscriminatorInJsonId and IncludeRootDiscriminatorInJsonId. We later decided to change the name, but #34403 only renamed IncludeDiscriminatorInJsonId to HasDiscriminatorInJsonId, and left IncludeRootDiscriminatorInJsonId as-is. This PR fixes that.
Customer impact
None - this is a new, unreleased API in 9.0.
How found
Discovered while writing documentation.
Regression
No.
Testing
Non required.
Risk
None, method name change only.